Skip to content

add 'parallel' to list of config templates#3036

Merged
boegel merged 4 commits intoeasybuilders:developfrom
migueldiascosta:parallel_template
Sep 30, 2019
Merged

add 'parallel' to list of config templates#3036
boegel merged 4 commits intoeasybuilders:developfrom
migueldiascosta:parallel_template

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

answers #2929?

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 27, 2019

@migueldiascosta Wait, does %(parallel)s actually ever get resolved when used in an easyconfig file?

@boegel boegel added this to the next release (4.0.1) milestone Sep 27, 2019
@migueldiascosta
Copy link
Copy Markdown
Member Author

@boegel with this change, yes... (just tried it again)

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 27, 2019

@migueldiascosta OK, but then we should get that properly covered in the tests too...

The non-None value for parallel is only available after a certain step (ready), see set_parallel in easyblock.py.

Done in migueldiascosta#9

enhance test for template_constant_dict to check 'parallel' template value after running 'ready' step
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 30, 2019

Thanks @migueldiascosta!

@boegel boegel merged commit 7e9ef96 into easybuilders:develop Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants