Skip to content

add 'retest' as a reason to --close-pr, to close/re-open PRs to trigger re-test in Travis#3040

Merged
boegel merged 3 commits intoeasybuilders:developfrom
migueldiascosta:trigger
Oct 12, 2019
Merged

add 'retest' as a reason to --close-pr, to close/re-open PRs to trigger re-test in Travis#3040
boegel merged 3 commits intoeasybuilders:developfrom
migueldiascosta:trigger

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this covered by the tests?

Comment thread easybuild/tools/github.py Outdated
'archived': 'uses an archived toolchain',
'inactive': 'no activity for > 6 months',
'obsolete': 'obsoleted by more recent PRs',
'reopen': 'closing and reopening to trigger tests',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe name it retest instead?

@boegel boegel added this to the next release (4.0.1) milestone Oct 2, 2019
@boegel boegel changed the title add closing to reopen as a reason to --close-pr add 'retest' as a reason to --close-pr, to close/re-open PRs to trigger re-test in Travis Oct 12, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 12, 2019

Tested with eb --pr-target-account hpcugent --pr-target-repo testrepository --close-pr 2 --close-pr-reasons=retest to close & re-open PR in test repo (easybuilders/testrepository#2), works like a charm.

Thanks @migueldiascosta!

@boegel boegel merged commit 528cd09 into easybuilders:develop Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants