Skip to content

fix use of obtain_file method for extensions#3042

Merged
wpoely86 merged 2 commits intoeasybuilders:developfrom
boegel:extension_obtain_file
Oct 3, 2019
Merged

fix use of obtain_file method for extensions#3042
wpoely86 merged 2 commits intoeasybuilders:developfrom
boegel:extension_obtain_file

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 2, 2019

Without the change in extensioneasyblock.py, the added test fails with:

ERROR: test_obtain_file_extension (test.framework.easyblock.EasyBlockTest)
Test use of obtain_file method on an extension.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/framework/easyblock.py", line 1259, in test_obtain_file_extension
    print ext.obtain_file(test_ext_src_fn)
  File "/Volumes/work/easybuild-framework/easybuild/framework/easyblock.py", line 635, in obtain_file
    if self.robot_path:
AttributeError: 'ExtensionEasyBlock' object has no attribute 'robot_path'

This fix is motivated by a need to use obtain_file in the TensorFlow easyblock, and by hitting that same error when installing a bundle that includes TensorFlow as extension...

@boegel boegel added the bug fix label Oct 2, 2019
@boegel boegel added this to the next release (4.0.1) milestone Oct 2, 2019
@wpoely86 wpoely86 merged commit 03e70cb into easybuilders:develop Oct 3, 2019
@boegel boegel deleted the extension_obtain_file branch October 3, 2019 06:23
@boegel boegel mentioned this pull request Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @wpoely86