update GitPython to latest version that supports Python 2.6 to fix broken test_new_update_pr#3066
Merged
wpoely86 merged 1 commit intoeasybuilders:developfrom Oct 31, 2019
Merged
Conversation
…oken test_new_update_pr
wpoely86
approved these changes
Oct 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_new_update_pris currently broken with Python 2.6 after merging @lexming's PR #3062, see https://travis-ci.org/easybuilders/easybuild-framework/builds/605032445.The GitHub tests are skipped for PRs to avoid leaking the GitHub token, so it went undetected in the PR tests.
The test fails because of a bug in GitPython, which was fixed in GitPython 2.1.8 (see gitpython-developers/GitPython#687), which apparently is also the latest version supported Python 2.6, see https://github.com/gitpython-developers/GitPython/blob/master/doc/source/changes.rst#219---dropping-support-for-python-26