Skip to content

flesh out env_vars_external_module from Toolchain._simulated_load_dependency_module#3088

Merged
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:env_vars_external_module
Nov 17, 2019
Merged

flesh out env_vars_external_module from Toolchain._simulated_load_dependency_module#3088
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:env_vars_external_module

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 16, 2019

... so we can leverage env_vars_external_module in easybuilders/easybuild-easyblocks#1849

@boegel boegel added the change label Nov 16, 2019
@boegel boegel added this to the next release (4.1.0) milestone Nov 16, 2019
Comment thread easybuild/tools/toolchain/toolchain.py Outdated
@boegel boegel force-pushed the env_vars_external_module branch from 9fc4baf to 31674e9 Compare November 16, 2019 20:22
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 301c21f into easybuilders:develop Nov 17, 2019
@boegel boegel deleted the env_vars_external_module branch November 17, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants