Skip to content

add better error message when mandatory key is missing from a dictionary easyconfig parameter#3092

Merged
akesandgren merged 2 commits intoeasybuilders:developfrom
migueldiascosta:dirs_sanity_check
Nov 22, 2019
Merged

add better error message when mandatory key is missing from a dictionary easyconfig parameter#3092
akesandgren merged 2 commits intoeasybuilders:developfrom
migueldiascosta:dirs_sanity_check

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

fixes #3022

@migueldiascosta migueldiascosta added this to the 4.1.0 milestone Nov 22, 2019
@akesandgren
Copy link
Copy Markdown
Contributor

That single github CI failure is a download fail unrelated to the commit.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 22, 2019

Damn fluke failures in GitHub, do I really have to invent another bot to automatically re-trigger those...

@migueldiascosta I've pushed in a minor style fix, mostly to re-trigger the tests, thanks for the fix!

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @migueldiascosta!

@akesandgren akesandgren merged commit 29edeca into easybuilders:develop Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EB crashes with KeyError when dirs key is not present in sanity_check_paths

3 participants