fix semantics of --set-default-module: only set default for specified easyconfigs, not for the ones that are installed as dependencies via --robot#3094
Merged
akesandgren merged 1 commit intoeasybuilders:developfrom Nov 24, 2019
Conversation
… easyconfigs, not for the ones that are installed as dependencies via --robot (fixes easybuilders#3090)
akesandgren
reviewed
Nov 24, 2019
| """Test use of --set-default-module --robot.""" | ||
| # create two test easyconfigs, one depending on the other | ||
| # (using dummy Toolchain easyblock included in the tests) | ||
| test_ec = os.path.join(self.test_prefix, 'test.eb') |
Contributor
There was a problem hiding this comment.
Won't verify-easyconfig-filenames=True in site easyconfig.cfg (or users) cause problems with that file name for someone running the tests locally?
Member
Author
There was a problem hiding this comment.
Could be, but if that's so then we need to isolate the tests from the user's configuration.
The tests are assumed to run with the default configuration.
Contributor
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3090