Skip to content

fix various issues in extracting comments from original easyconfig file and including them again in dumped easyconfig#3095

Merged
akesandgren merged 9 commits intoeasybuilders:developfrom
boegel:fix_dump_comments
Nov 24, 2019
Merged

fix various issues in extracting comments from original easyconfig file and including them again in dumped easyconfig#3095
akesandgren merged 9 commits intoeasybuilders:developfrom
boegel:fix_dump_comments

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 24, 2019

…le and including them again in dumped easyconfig
@boegel boegel added the bug fix label Nov 24, 2019
@boegel boegel added this to the 4.1.0 milestone Nov 24, 2019
Comment thread easybuild/framework/easyconfig/format/one.py Outdated
Comment thread easybuild/framework/easyconfig/format/one.py Outdated
Comment thread easybuild/framework/easyconfig/format/one.py Outdated
Comment thread easybuild/framework/easyconfig/format/one.py Outdated
Comment thread test/framework/easyconfig.py
Comment thread easybuild/framework/easyconfig/format/one.py
Comment thread easybuild/framework/easyconfig/format/one.py
Comment thread easybuild/framework/easyconfig/format/one.py Outdated
Comment thread test/framework/easyconfig.py Outdated
Comment thread test/framework/easyconfig.py Outdated
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit cc753bc into easybuilders:develop Nov 24, 2019
@boegel boegel deleted the fix_dump_comments branch November 24, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misplaced comments after parsing and dumping of recipes

3 participants