Skip to content

make including 'extensions' statement in generated Lua module files opt-in for now#3107

Merged
akesandgren merged 1 commit intoeasybuilders:4.1.xfrom
boegel:extensions_opt_in
Nov 30, 2019
Merged

make including 'extensions' statement in generated Lua module files opt-in for now#3107
akesandgren merged 1 commit intoeasybuilders:4.1.xfrom
boegel:extensions_opt_in

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 30, 2019

Lmod apparently chokes on a module file is the list of extensions is too long (which is the case for Perl) after including an extensions statement (see @wpoely86's PR #3085):

== 2019-11-30 08:50:24,617 build_log.py:164 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:124 in __init__): Module command 'module load Perl/5.30.0-GCCcore-8.3.0' failed with exit code 1; stderr: Lmod has detected the following error: Unable to load module because of error when evaluating modulefile:
     /tmp/eb-idlfoc6k/tmp2s1c6_jv/all/Perl/5.30.0-GCCcore-8.3.0.lua: [string "help([==[..."]:118: function or expression needs too many registers near '"Test::Simple/1.302168"'
     Please check the modulefile and especially if there is a the line number specified in the above message
While processing the following module(s):
    Module fullname            Module Filename
    ---------------            ---------------
    Perl/5.30.0-GCCcore-8.3.0  /tmp/eb-idlfoc6k/tmp2s1c6_jv/all/Perl/5.30.0-GCCcore-8.3.0.lua
; stdout:
false
 (at easybuild/tools/modules.py:758 in run_module)

It may have something to do with the complete module file being too large, since we include the list of extensions 3 times now (in description, in whatis, in extensions)...

So for now, let's make including an extensions statement in the generated module file opt-in, until we figure out this issue (or have a fix in Lmod).

@boegel
make including 'extensions' statement in generated Lua module files o…
3f66489 
…pt-in for now, since Lmod chokes on long list of extensions
@boegel boegel added this to the 4.1.0 milestone Nov 30, 2019
@boegel boegel requested a review from wpoely86 November 30, 2019 08:37
@boegel boegel changed the base branch from develop to 4.1.x November 30, 2019 08:38
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 30, 2019

Also reported this to Lmod: TACC/Lmod#428

akesandgren
akesandgren approved these changes Nov 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Nov 30, 2019

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 288ebc5 into easybuilders:4.1.x Nov 30, 2019
@boegel boegel deleted the extensions_opt_in branch November 30, 2019 10:50
@boegel boegel mentioned this pull request Nov 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @akesandgren @wpoely86