read patch files as bytestring to avoid UnicodeDecodeError for patches that include funky characters#3191
Merged
zao merged 9 commits intoeasybuilders:developfrom Feb 10, 2020
Merged
Conversation
…s that include funky characters (fixes easybuilders#3190)
zao
reviewed
Feb 8, 2020
… patch contents, following @zao's suggestion
7190ca2 to
3f369d6
Compare
Contributor
|
Regarding the Travis failure for 2.6 - the docs for str.encode say:
|
…ey're not supported in Python 2.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3190