Skip to content

Restore flake8 default ignores#3193

Merged
boegel merged 3 commits intoeasybuilders:developfrom
ocaisa:flake8_warnings
Feb 10, 2020
Merged

Restore flake8 default ignores#3193
boegel merged 3 commits intoeasybuilders:developfrom
ocaisa:flake8_warnings

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Feb 7, 2020

No description provided.

@easybuilders easybuilders deleted a comment from boegelbot Feb 7, 2020
@easybuilders easybuilders deleted a comment from boegelbot Feb 7, 2020
@easybuilders easybuilders deleted a comment from boegelbot Feb 7, 2020
@ocaisa ocaisa closed this Feb 7, 2020
@ocaisa ocaisa reopened this Feb 7, 2020
@easybuilders easybuilders deleted a comment from boegelbot Feb 7, 2020
@ocaisa ocaisa closed this Feb 7, 2020
@ocaisa ocaisa reopened this Feb 7, 2020
@easybuilders easybuilders deleted a comment from boegelbot Feb 7, 2020
@boegel boegel added the change label Feb 8, 2020
@boegel boegel added this to the next release (4.1.2?) milestone Feb 8, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 8, 2020

@ocaisa Can you clarify this?

Did we actually start complaining about more style issues because of the change made in #3162?

Where did you get this default list from?

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Feb 8, 2020

Did we actually start complaining about more style issues because of the change made in #3162?

Yes, by giving an explicit ignore we've overridden the default ignores leading to annoying loops as found in #3186 (comment)

Where did you get this default list from?

It's the flake8 default for v3.5.0, see flake8 --help and check --ignore=errors

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Feb 10, 2020

I updated this to only extend the warnings, this requires flake8 >= 3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants