Optionally call log.warning in print_warning#3195
Merged
boegel merged 2 commits intoeasybuilders:developfrom Feb 29, 2020
Merged
Optionally call log.warning in print_warning#3195boegel merged 2 commits intoeasybuilders:developfrom
boegel merged 2 commits intoeasybuilders:developfrom
Conversation
1 task
boegel
approved these changes
Feb 29, 2020
Member
boegel
left a comment
There was a problem hiding this comment.
@Flamefire lgtm, but I did enhance the test for the print_warning function to also test the use of the log argument...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful e.g. here: https://github.com/easybuilders/easybuild-easyblocks/pull/1949/files#r377017117