Skip to content

fix broken test for --review-pr by using different PR to test with#3226

Merged
smoors merged 1 commit intoeasybuilders:developfrom
boegel:fix_broken_review_pr
Mar 3, 2020
Merged

fix broken test for --review-pr by using different PR to test with#3226
smoors merged 1 commit intoeasybuilders:developfrom
boegel:fix_broken_review_pr

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 3, 2020

test_review_pr is broken since CMake easyconfigs require a custom easyblock (see easybuilders/easybuild-easyconfigs#9923):

ERROR: test_review_pr (__main__.CommandLineOptionsTest)
Test --review-pr.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/work/easybuild-framework/test/framework/options.py", line 2719, in test_review_pr
    self.eb_main(args, raise_error=True)
  File "test/framework/utilities.py", line 297, in eb_main
    raise myerr
EasyBuildError: "Failed to process easyconfig /tmp/eb-2CkwCb/eb-9LDged/eb-GkRZEb/eb-pm6zll/tmpOGHyGY/c/CMake/CMake-3.12.1-GCCcore-7.3.0.eb: No software-specific easyblock 'EB_CMake' found for CMake"

fixed by using easybuilders/easybuild-easyconfigs#9921 instead (which uses ConfigureMake, and we have a dummy ConfigureMake easyblock included in the framework tests)

This test is skipped when testing framework PRs because it requires a GitHub token to run (to avoid hitting GitHub rate limits when running the tests), but I verified the fix locally.

@boegel boegel added the bug fix label Mar 3, 2020
@boegel boegel added this to the next release (4.1.2?) milestone Mar 3, 2020
smoors
smoors approved these changes Mar 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Mar 3, 2020

Going in, thanks @boegel!

@smoors smoors merged commit f846665 into easybuilders:develop Mar 3, 2020
@boegel boegel deleted the fix_broken_review_pr branch March 3, 2020 17:59
@boegel boegel mentioned this pull request Mar 16, 2020
Merged
@boegel boegel modified the milestones: next release (4.2.0), 4.1.2 Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @smoors