Skip to content

unset $GITHUB_TOKEN in Travis after installing token, to avoid failing test_from_pr_token_log#3252

Merged
zao merged 1 commit intoeasybuilders:developfrom
boegel:unset_GITHUB_TOKEN_travis
Mar 21, 2020
Merged

unset $GITHUB_TOKEN in Travis after installing token, to avoid failing test_from_pr_token_log#3252
zao merged 1 commit intoeasybuilders:developfrom
boegel:unset_GITHUB_TOKEN_travis

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 21, 2020

test_from_pr_token_log was failing outside of the context of testing a PR, because the contents of the $GITHUB_TOKEN environment variable set in the Travis environment was included in the environment dump that is included in EasyBuild debug logs...

@boegel boegel added the bug fix label Mar 21, 2020
@boegel boegel added this to the next release (4.2.0) milestone Mar 21, 2020
Copy link
Copy Markdown
Contributor

@zao zao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zao zao merged commit 505919a into easybuilders:develop Mar 21, 2020
@zao
Copy link
Copy Markdown
Contributor

zao commented Mar 21, 2020

Going in, thanks @boegel!

@boegel boegel deleted the unset_GITHUB_TOKEN_travis branch March 22, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants