fix posting of comment in PR with --upload-test-report#3272
Merged
zao merged 1 commit intoeasybuilders:developfrom Apr 8, 2020
Merged
fix posting of comment in PR with --upload-test-report#3272zao merged 1 commit intoeasybuilders:developfrom
zao merged 1 commit intoeasybuilders:developfrom
Conversation
zao
approved these changes
Apr 8, 2020
Contributor
zao
left a comment
There was a problem hiding this comment.
-u works again with this PR for me.
Contributor
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for bug that was introduced in recently merged PR #3189 that occurs when
--upload-test-report:The underlying cause was the use of
Nonein the URL composed to post the comment by thepost_comment_in_issuefunction (called bypost_easyconfigs_pr_test_report), for example:This occurs because the default value for
--pr-target-repowas changed toNonein #3189...