get pr_title and pr_descr built_options in new_pr_from_branch instead of new_pr (and commit_msg in both)#3298
Merged
boegel merged 2 commits intoeasybuilders:developfrom May 1, 2020
Conversation
… of new_pr (and commit_msg in both)
Contributor
|
@migueldiascosta Did you test it? |
Member
Author
|
@ake I did I can also modify --- a/test/framework/options.py
+++ b/test/framework/options.py
@@ -3308,6 +3308,7 @@ class CommandLineOptionsTest(EnhancedTestCase):
'--new-pr-from-branch=%s' % test_branch,
'--github-user=%s' % GITHUB_TEST_ACCOUNT, # used to get GitHub token
'--github-org=boegel', # used to determine account to grab branch from
+ '--pr-descr="an easyconfig for toy"',
'-D',
]
txt, _ = self._run_mock_eb(args, do_build=True, raise_error=True, testing=False)
@@ -3326,6 +3327,7 @@ class CommandLineOptionsTest(EnhancedTestCase):
r"\* target: easybuilders/easybuild-easyconfigs:develop$",
r"^\* from: boegel/easybuild-easyconfigs:test_new_pr_from_branch_DO_NOT_REMOVE$",
r'^\* title: "\{tools\}\[system/system\] toy v0\.0"$',
+ r'^"an easyconfig for toy"$',
r"^ 1 file changed, 32 insertions\(\+\)$",
r"^\* overview of changes:\n easybuild/easyconfigs/t/toy/toy-0\.0\.eb | 32",
](?) |
Contributor
|
Then I think you should add that to the test just to prove it works :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #3295