always take into account builddependencies when generating template values, also when we're not iterating over builddependencies#3346
Merged
boegel merged 12 commits intoeasybuilders:developfrom Jul 3, 2020
Conversation
boegel
requested changes
Jul 3, 2020
…nt_dict is not an EasyConfig instance yet + add comments to clarify what's going on
also consider builddependencies when config passed to template_constant_dict is not an EasyConfig instance yet + add comments to clarify what's going on
boegel
requested changes
Jul 3, 2020
Co-authored-by: Kenneth Hoste <[email protected]>
Co-authored-by: Kenneth Hoste <[email protected]>
…n EasyConfig instance
boegel
previously approved these changes
Jul 3, 2020
d3d0149 to
44b03c5
Compare
boegel
approved these changes
Jul 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3300, fixes #2114