Also put easyblocks used by extensions in reprod directory#3375
Merged
akesandgren merged 4 commits intoeasybuilders:developfrom Jul 2, 2020
Merged
Also put easyblocks used by extensions in reprod directory#3375akesandgren merged 4 commits intoeasybuilders:developfrom
reprod directory#3375akesandgren merged 4 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
@boegel Any idea how I could test this? |
Member
Author
|
Ok, I have a test, trying to make it pass now... |
added 2 commits
July 1, 2020 14:16
The reproduction directory is created before we run the steps, when the list of extension easyblock instances is not actually populated yet
Contributor
|
Going in, thanks @ocaisa! |
boegel
reviewed
Jul 4, 2020
| easyblock_path = inspect.getsourcefile(easyblock_class) | ||
| # if we reach EasyBlock or ExtensionEasyBlock class, we are done | ||
| # (ExtensionEasyblock is hardcoded to avoid a cyclical import) | ||
| if easyblock_class.__name__ in [EasyBlock.__name__, 'ExtensionEasyBlock']: |
Member
There was a problem hiding this comment.
@ocaisa To be on the safe side, we also should consider 'Extension' here... In theory there could be extensions that are installed with a class that directly derives from Extension rather than ExtensionEasyBlock (we don't have any like these currently in the central easyblocks repository though....)
Member
Author
There was a problem hiding this comment.
@boegel This comes at no cost right, I should do this
boegel
reviewed
Jul 4, 2020
| else: | ||
| copy_file(easyblock_path, os.path.join(reprod_easyblock_dir, easyblock_filename)) | ||
| _log.info("Dumped easyblock %s required for reproduction to %s", easyblock_filename, reprod_easyblock_dir) | ||
| # also archive all the relevant easyblocks (including any used by extensions) |
Member
There was a problem hiding this comment.
Comment is incorrect, archiving of easyblocks used by extensions is not done here?
boegel
added a commit
to ocaisa/easybuild-framework
that referenced
this pull request
Jul 4, 2020
…olved correctly) + fix comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3373