also escape backslashes in quote_py_str()#3386
Merged
boegel merged 4 commits intoeasybuilders:developfrom Aug 9, 2020
Merged
Conversation
Contributor
Author
|
My initial approach with |
boegel
requested changes
Aug 5, 2020
boegel
approved these changes
Aug 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances
quote_py_str()to also escape all backslashes. Otherwise parse tests may fail due to divergences between the provided and dumped easyconfig. That's becausequote_py_str()is limited to quotes and new lines, while several options such aspreconfigopts,prebuildoptsorpostintallcmdscan potentially contain any string literal.This fixes the failed tests of easybuilders/easybuild-easyconfigs#10965