Skip to content

fix default value for 'lib64_fallback_sanity_check' build option#3402

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:fix_default_lib64_fallback_sanity_check_build_option
Aug 14, 2020
Merged

fix default value for 'lib64_fallback_sanity_check' build option#3402
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:fix_default_lib64_fallback_sanity_check_build_option

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 14, 2020

--lib64-fallback-sanity-check is enabled by default, so the correct default value for the corresponding build option is True, not False

This has no impact in normal circumstances, since the default values for build options are not actually used during normal configuration (when using eb or after calling set_up_configuration when leveraging EasyBuild as a library).

Thanks to @Flamefire for raising this issue...

@boegel boegel added the bug fix label Aug 14, 2020
@boegel boegel added this to the next release (4.2.3?) milestone Aug 14, 2020
@boegel boegel requested a review from migueldiascosta August 14, 2020 09:20
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 687bcbb into easybuilders:develop Aug 14, 2020
@boegel boegel deleted the fix_default_lib64_fallback_sanity_check_build_option branch August 14, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants