Skip to content

exclude local variables from typo check in easyconfig files#3427

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:fix_local_var_typo_detect
Sep 2, 2020
Merged

exclude local variables from typo check in easyconfig files#3427
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:fix_local_var_typo_detect

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Sep 2, 2020

Avoids misdetection of e.g. local_cuda_compute_capabilities

example:

Failed to process easyconfig /tmp/RELION-2.1-fosscuda-2017b.eb:
You may have some typos in your easyconfig file: local_cuda_compute_capabilities -> cuda_compute_capabilities

Avoids misdetection of e.g. local_cuda_compute_capabilities
@boegel boegel changed the title Don't check local variables in ECs for typos exclude local variables from typo check in easyconfig files Sep 2, 2020
@boegel boegel added this to the next release (4.3.0) milestone Sep 2, 2020
@boegel boegel added the bug fix label Sep 2, 2020
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 2, 2020

Thanks for the fix @Flamefire!

@boegel boegel merged commit d80d797 into easybuilders:develop Sep 2, 2020
@Flamefire Flamefire deleted the fix_local_var_typo_detect branch September 2, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants