Skip to content

Use only the sub folder name for createSubmoduleDeps script#3464

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:simplify_createSubmoduleDeps
Oct 12, 2020
Merged

Use only the sub folder name for createSubmoduleDeps script#3464
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:simplify_createSubmoduleDeps

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

This reduces boilerplate in the generated code.
Example: 'extract_cmd': local_extract_cmd_pattern % 'NNPACK',

This reduces boilerplate in the generated code.
Example:  `'extract_cmd': local_extract_cmd_pattern % 'NNPACK',`
@boegel boegel changed the title Use only the sub folder name for createSubmoduleDeps Use only the sub folder name for createSubmoduleDeps script Oct 12, 2020
@boegel boegel added the change label Oct 12, 2020
@boegel boegel added this to the next release (4.3.1) milestone Oct 12, 2020
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit e741113 into easybuilders:develop Oct 12, 2020
@Flamefire Flamefire deleted the simplify_createSubmoduleDeps branch October 12, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants