Skip to content

avoid confusing error log message when determining impi version while trying to define value for %(mpi_cmd_prefix)s template#3474

Merged
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:fix_mpi_cmd_prefix_template_error
Oct 20, 2020
Merged

avoid confusing error log message when determining impi version while trying to define value for %(mpi_cmd_prefix)s template#3474
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:fix_mpi_cmd_prefix_template_error

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 19, 2020

just return None, and take this into account in Mpi.mpi_cmd_prefix

fixes #3442

…ne, and take this into account in Mpi.mpi_cmd_prefix (fixes easybuilders#3442)
@boegel boegel added the bug fix label Oct 19, 2020
@boegel boegel added this to the next release (4.3.1) milestone Oct 19, 2020
@boegel boegel requested a review from bartoldeman October 19, 2020 20:18
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit e658179 into easybuilders:develop Oct 20, 2020
@boegel boegel deleted the fix_mpi_cmd_prefix_template_error branch October 20, 2020 08:01
@boegel boegel changed the title don't raise error when Mpi.mpi_cmd_for fails for impi avoid confusing error log message when determining impi version while trying to define value for %(mpi_cmd_prefix) template Oct 28, 2020
@boegel boegel changed the title avoid confusing error log message when determining impi version while trying to define value for %(mpi_cmd_prefix) template avoid confusing error log message when determining impi version while trying to define value for %(mpi_cmd_prefix)s template Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build succesfully proceed regardless of error in get_software_version() with iimpi toolchain

2 participants