Skip to content

don't include file/ldd/readelf commands run during RPATH sanity check in --trace output#3508

Merged
Micket merged 1 commit intoeasybuilders:developfrom
boegel:rpath_sanity_check_no_trace
Nov 28, 2020
Merged

don't include file/ldd/readelf commands run during RPATH sanity check in --trace output#3508
Micket merged 1 commit intoeasybuilders:developfrom
boegel:rpath_sanity_check_no_trace

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 28, 2020

The RPATH-specific part of the sanity check step is currently overly verbose when using eb --rpath --trace:

== sanity checking...
  >> running command:
        [started at: 2020-11-28 16:33:52]
        [working dir: /home/centos/EasyBuild/EasyBuild-4.3.1/build/binutils/2.31.1/system-system/binutils-2.31.1]
        [output logged in /tmp/eb-nplkyey8/easybuild-run_cmd-sxcm8f0k.log]
        file /home/centos/EasyBuild/EasyBuild-4.3.1/software/binutils/2.31.1/bin/addr2line
  >> command completed: exit 0, ran in < 1s
  >> running command:
        [started at: 2020-11-28 16:33:52]
        [working dir: /home/centos/EasyBuild/EasyBuild-4.3.1/build/binutils/2.31.1/system-system/binutils-2.31.1]
        [output logged in /tmp/eb-nplkyey8/easybuild-run_cmd-fqacpwfs.log]
        ldd /home/centos/EasyBuild/EasyBuild-4.3.1/software/binutils/2.31.1/bin/addr2line
  >> command completed: exit 0, ran in < 1s
...

The changes in this PR avoid including the file, ldd and readelf commands in the --trace output.

@boegel boegel added this to the 4.3.2 (next release) milestone Nov 28, 2020
Micket
Micket approved these changes Nov 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 34627ca into easybuilders:develop Nov 28, 2020
@boegel boegel deleted the rpath_sanity_check_no_trace branch November 28, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.3.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @Micket