Skip to content

tweak test_easystack_basic to get better error reporting if it fails#3511

Merged
migueldiascosta merged 2 commits intoeasybuilders:developfrom
boegel:fix_easystack_tests
Dec 1, 2020
Merged

tweak test_easystack_basic to get better error reporting if it fails#3511
migueldiascosta merged 2 commits intoeasybuilders:developfrom
boegel:fix_easystack_tests

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 1, 2020

No description provided.

@boegel boegel added the bug fix label Dec 1, 2020
@boegel boegel added this to the 4.3.2 (next release) milestone Dec 1, 2020
@migueldiascosta
Copy link
Copy Markdown
Member

@boegel this will still not show the actual error, maybe first check that err is empty and print it if it is not?

Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit dea39f5 into easybuilders:develop Dec 1, 2020
@boegel boegel deleted the fix_easystack_tests branch December 1, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants