avoid metadata greedy behaviour when probing for external module metadata#3559
Merged
boegel merged 4 commits intoeasybuilders:developfrom May 19, 2021
Merged
Conversation
Member
|
@victorusu Can you look into the failing test? |
…me thereof in probe_external_module_metadata + fix test
boegel
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the greedy behaviour from the metadata handler.
The greedy behaviour causes this type of issues (eth-cscs/production#2106).
Currently, the metadata file parser populates the
PACKAGE_PREFIXandPACKAGE_VERSIONvariables at the moment it reads the file. This might be ok for non Cray systems, due to the fact that the modules are may still be present and have the same values. For Cray systems, the value of the fields change with the change in the programming environment. In this case, one needs to let EB populate the values at the very end.