Skip to content

avoid initializing Toolchain instance when taking into account toolchain dependencies for templates#3560

Merged
lexming merged 2 commits intoeasybuilders:developfrom
boegel:test_cudaver_toolchain
Feb 3, 2021
Merged

avoid initializing Toolchain instance when taking into account toolchain dependencies for templates#3560
lexming merged 2 commits intoeasybuilders:developfrom
boegel:test_cudaver_toolchain

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 2, 2021

This was missing in #3541.

The test fails without the changes in #3541...

@boegel boegel added this to the next release (4.3.3?) milestone Feb 2, 2021
@boegel boegel requested a review from lexming February 2, 2021 14:04
@boegel
avoid initializing Toolchain instance when taking into account toolch…
6b119a6 
…ain dependencies for templates + revert change from easybuilders#3541 to test from which started failing because of triggering early Toolchain initialization
@boegel boegel changed the title add test for defining %(cudaver)s template via toolchain avoid initializing Toolchain instance when taking into account toolchain dependencies for templates Feb 2, 2021
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Feb 3, 2021

As expected, the test fails if cudaver is not defined:

======================================================================
ERROR: test_templating_cuda_toolchain (__main__.EasyConfigTest)
Test templates via toolchain component, like setting %(cudaver)s with fosscuda toolchain.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/theia/home/brussel/101/vsc10122/src/easybuild-framework/test/framework/easyconfig.py", line 1094, in test_templating_cuda_toolchain
    self.assertEqual(ec.template_values['cudaver'], '10.1.243')
KeyError: 'cudaver'

----------------------------------------------------------------------
Ran 82 tests in 625.336s

FAILED (errors=1)

lexming
lexming approved these changes Feb 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming merged commit 5c695af into easybuilders:develop Feb 3, 2021
@boegel boegel deleted the test_cudaver_toolchain branch February 4, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @lexming