fix failing GitHub tests due to trivial change in output of 'eb' command#3583
Merged
ocaisa merged 3 commits intoeasybuilders:developfrom Feb 19, 2021
Merged
fix failing GitHub tests due to trivial change in output of 'eb' command#3583ocaisa merged 3 commits intoeasybuilders:developfrom
ocaisa merged 3 commits intoeasybuilders:developfrom
Conversation
ocaisa
approved these changes
Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the GitHub tests starting failing due to a trivial change in #3472, where the
ebcommand now prints "Temporary log file in case of crash" rather then "temporary log file in case of crash" (capitalT).This went undetected in the PR tests because the GitHub-related tests are skipped for PRs, because the GitHub token is not available then (to avoid that it can be leaked by a malicious PR), but they are still run when the PR is merged to
develop.I'm also limiting the use of the GitHub token a bit here, to avoid hitting the GitHub rate limit now that we're running additional test configurations (cfr. #3565). There's little point in running the GitHub tests with different module tools...