Skip to content

also check for pending change requests and mergeable_state in check_pr_eligible_to_merge#3604

Merged
boegel merged 2 commits intoeasybuilders:developfrom
migueldiascosta:check_reviews_in_merge_pr
Mar 11, 2021
Merged

also check for pending change requests and mergeable_state in check_pr_eligible_to_merge#3604
boegel merged 2 commits intoeasybuilders:developfrom
migueldiascosta:check_reviews_in_merge_pr

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Mar 9, 2021 •
edited by boegel
Loading

fixes #3603, fixes #3293

@migueldiascosta migueldiascosta added this to the next release (4.3.4?) milestone Mar 9, 2021
@migueldiascosta migueldiascosta changed the title also check for pending change requests in check_pr_eligible_to_merge also check for pending change requests and mergeable_state in check_pr_eligible_to_merge Mar 9, 2021
boegel
boegel approved these changes Mar 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit ca330ea into easybuilders:develop Mar 11, 2021
@branfosj branfosj mentioned this pull request Mar 11, 2021
Closed
@boegel boegel mentioned this pull request Apr 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

--merge-pr fails when the PR has a 'Request changes' review on it Better handling of status checks required in --merge-pr

2 participants

@migueldiascosta @boegel