added configuration option to define the env command to use for shebangs#3613
Merged
boegel merged 5 commits intoeasybuilders:developfrom Mar 16, 2021
Merged
Conversation
boegel
requested changes
Mar 16, 2021
boegel
requested changes
Mar 16, 2021
Member
boegel
left a comment
There was a problem hiding this comment.
@mboisson Test problem is fixed with ComputeCanada#24
pass custom env command in test_fix_shebang via --env-for-shebang command line option
boegel
approved these changes
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the feature introduced in PR #2878, it can break some scripts, because the arguments following the command are passed as a single argument. This is fixed in recent
envby providing the option-S. This is however not available on all operating systems. Notably, the/usr/bin/envprovided by CentOS7 does not support that.This PR makes this a configuration option that sites can use to point to a different
envcommand and optionally specify the-Sargument if supported by their OS.