Skip to content

use develop branch when testing push access in --check-github#3629

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:check_github_develop
Apr 6, 2021
Merged

use develop branch when testing push access in --check-github#3629
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:check_github_develop

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 5, 2021

fixes #3590

This will make the switch from master to main a bit less painful, and we should be using develop instead anyway for this...

@boegel boegel added the change label Apr 5, 2021
@boegel boegel added this to the next release (4.3.4?) milestone Apr 5, 2021
@boegel boegel requested a review from migueldiascosta April 5, 2021 20:40
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 15f1d82 into easybuilders:develop Apr 6, 2021
@boegel boegel deleted the check_github_develop branch April 6, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github hooks should check against develop branch

2 participants