Don't skip sanity check for --module-only --rebuild#3645
Don't skip sanity check for --module-only --rebuild#3645ocaisa merged 2 commits intoeasybuilders:developfrom
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'm in favor of this change, it's indeed useful to still (re)do the sanity checks with |
|
@smoors The sanity check for extensions are always skipped when using If we change/fix that, we would definitely need an |
|
I definitely believe this should be the case, in my case I would like to sanity check the EESSI installations on my own system (since I was building my own module tree stack I was just using |
|
@ocaisa : What exactly is the behavior you want? NOT running the sanity check when module-only is used? You can use |
I updated my comment, I was wrong in what I originally said. I definitely agree that running the sanity check should be done when combining |
that's why I proposed to change it so that
sure, then you can do |
|
@Flamefire Do you think you will implement the Personally I believe you should run the sanity checks for extensions too. The R extensions in |
|
@ocaisa Makes sense to run the sanity check for extensions too. Not sure if or when I have time for that, so do create an issue for this and if someone works on that soon, then the better |
The only difference to now us that the sanity check is run when
--rebuildis used.For "proper" use, i.e. regenerating a module, this does not cause any problems and might even show issues that user was not aware of.
For those that used it for something else, the sanity check can fail and those need to use
--forceinstead.So that is IMO very low impact.
I'd even say it is a bugfix as the comment states: "allow skipping sanity check too when only generating module and force is used"