Improve logging when failing to load class from exts_classmap#3657
Merged
bartoldeman merged 1 commit intoeasybuilders:developfrom Apr 21, 2021
Merged
Improve logging when failing to load class from exts_classmap#3657bartoldeman merged 1 commit intoeasybuilders:developfrom
bartoldeman merged 1 commit intoeasybuilders:developfrom
Conversation
Posted in Slack: TypeError: __init__() takes 2 positional arguments but 3 were given This was not caught and "enhanced" by the information which class was tried to load. This change catches the base Exception class, which includes TypeError. It also logs the class found before instantiating it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posted in Slack:
This was not caught and "enhanced" by the information which class wastried to load.
This change catches the base Exception class, which includes TypeError.
It also logs the class found before instantiating it.