Skip to content

Replace log_error parameter of which() by on_error#3661

Merged
smoors merged 1 commit intoeasybuilders:developfrom
Flamefire:enhance_which
Apr 27, 2021
Merged

Replace log_error parameter of which() by on_error#3661
smoors merged 1 commit intoeasybuilders:developfrom
Flamefire:enhance_which

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

This allows to additionally make the warning an error instead of only being able to ignore it.
This is useful if the command must be found.

This allows to additionally make the warning an error instead of only
being able to ignore it.
This is useful if the command must be found.
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Apr 27, 2021

Going in, thanks @Flamefire!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants