allow tweaking of easyconfigs from different toolchains#3669
Merged
ocaisa merged 2 commits intoeasybuilders:developfrom Dec 14, 2023
Merged
allow tweaking of easyconfigs from different toolchains#3669ocaisa merged 2 commits intoeasybuilders:developfrom
ocaisa merged 2 commits intoeasybuilders:developfrom
Conversation
bartoldeman
previously requested changes
May 6, 2021
2cdca4e to
14865c2
Compare
Contributor
|
This looks sane to me, but I think @boegel needs to take a look at it too... |
f04639f to
7106d8f
Compare
Contributor
Author
|
Rebased again |
7106d8f to
0c60a5a
Compare
Contributor
|
@boegel I think your eyes are needed on this |
0c60a5a to
4a0b6fb
Compare
This is useful to bulk-install e.g. Python with enable_lto=False set for all ECs. The restriction is only required when changing the toolchain so move the check down and add a simple test.
4a0b6fb to
b9f33ea
Compare
Contributor
Author
|
ping |
ocaisa
approved these changes
Dec 13, 2023
Member
ocaisa
left a comment
There was a problem hiding this comment.
I think this is ok, and the test is there
Tweaking is hard to test, but this has tests and the specific use case is clear
Member
|
@Flamefire Not sure why the full test suite hasn't run on this, it won't let me merge as is |
Contributor
Author
I guess some required checks have since been removed. I merged develop to restart CI and see if that solves it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful to bulk-install e.g. Python with enable_lto=False set for all ECs.
The restriction is only required when changing the toolchain so move the check down and add a simple test.