extend sanity check step to check whether specific libraries are not linked into installed binaries/libraries#3678
Conversation
…) linked into installed binaries/libraries (WIP)
…arnings + rename named arguments to avoid confusion
…ared_libs + add test to verify it works as intended
… libs property methods
…in sanity check step
…esn't link to libtoy.so)
|
Tests are failing because the new test easyblock for edit: and then of course you realize the problem... fixed in f657d64 |
…was not getting expanded in mkdir command)
Micket
left a comment
There was a problem hiding this comment.
As far as I can tell, this (understandably) requires opt-in, so, it certainly won't help to catch inadvertent linking?
It will help if we opt-in to checking stuff like I don't think we should be hardcoding things like this, it should be left as opt-in imho... It does catch linking the |
This is still work-in-progress, because it now hardcodesopenblasas a banned library, which is obviously not the intention...We should figure out where the list of required/banned libraries will come from.One obvious way is to provide a dedicated configuration option like--banned-libraries, but we also need a way to pick up additional banned libraries from the toolchain, for example when using FlexiBLAS (since then all the backend libraries should be banned from linking to directly).This will also be useful to ensure there are no direct links to the OpenSSL libraries provided by the OS (cfr. easybuilders/easybuild-easyconfigs#11895 (comment)), or to
libz.so,libcurl.so, etc.To do: