Skip to content

use unload/load in ModuleGeneratorLua.swap_module, since 'swap' is not supported by Lmod#3685

Merged
migueldiascosta merged 2 commits intoeasybuilders:developfrom
boegel:fix_swap_lua
May 20, 2021
Merged

use unload/load in ModuleGeneratorLua.swap_module, since 'swap' is not supported by Lmod#3685
migueldiascosta merged 2 commits intoeasybuilders:developfrom
boegel:fix_swap_lua

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 18, 2021

fixes #3626

@boegel boegel added bug fix cray Issues and PRs related to integration with Cray PE labels May 18, 2021
@boegel boegel added this to the next release (4.4.0) milestone May 18, 2021
@boegel boegel changed the title use unload/load in ModuleGeneratorLua.swap_module, since 'swap' is not supported by Lmod (fixes #3626) use unload/load in ModuleGeneratorLua.swap_module, since 'swap' is not supported by Lmod May 18, 2021
@boegel boegel requested a review from migueldiascosta May 19, 2021 19:32
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit b03612a into easybuilders:develop May 20, 2021
@boegel boegel deleted the fix_swap_lua branch May 20, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix cray Issues and PRs related to integration with Cray PE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error creating Cray toolchain modulefiles with Lua syntax

2 participants