allow opting out of recursively unloaded of modules via recursive_module_unload easyconfig parameter#3689
Merged
migueldiascosta merged 2 commits intoeasybuilders:developfrom May 21, 2021
Conversation
…ule_unload easyconfig parameter
…dule file when using Lua syntax
| is_loaded_regex = re.compile(r"if { !\[is-loaded gompi/2018a\] }", re.M) | ||
|
|
||
| toy_module_txt = read_file(toy_module) | ||
| is_loaded_regex = re.compile(r"if { !\[is-loaded gompi/2018a\] }", re.M) |
Member
There was a problem hiding this comment.
so, with Lua this test wasn't actually testing? (just checking if I understand)
Member
Author
There was a problem hiding this comment.
Indeed. We were checking for a missing pattern using a Tcl regex pattern in a Lua module file.
That probably shows this test should be rewritten a bit, but I just wanted to fix the obvious problem when I noticed it.
Member
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cfr. #3627