Skip to content

fix extending message for changed files in new_pr_from_branch#3699

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:fix_new_pr_from_branch
May 26, 2021
Merged

fix extending message for changed files in new_pr_from_branch#3699
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:fix_new_pr_from_branch

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 25, 2021

fix for following crash in test_new_pr_from_branch, but it's unclear to me why it doesn't pop up consistently...

ERROR: test_new_pr_from_branch (test.framework.options.CommandLineOptionsTest)
Test --new-pr-from-branch.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/runner/3d5a10931cf2e751ef06d2399c598a7f9581f7da/lib/python3.8/site-packages/test/framework/options.py", line 3987, in test_new_pr_from_branch
    txt, _ = self._run_mock_eb(args, do_build=True, raise_error=True, testing=False)
  File "/tmp/runner/3d5a10931cf2e751ef06d2399c598a7f9581f7da/lib/python3.8/site-packages/test/framework/options.py", line 3883, in _run_mock_eb
    self.eb_main(args, **kwargs)
  File "/tmp/runner/3d5a10931cf2e751ef06d2399c598a7f9581f7da/lib/python3.8/site-packages/test/framework/utilities.py", line 314, in eb_main
    raise myerr
  File "/tmp/runner/3d5a10931cf2e751ef06d2399c598a7f9581f7da/lib/python3.8/site-packages/test/framework/utilities.py", line 287, in eb_main
    main(args=args, logfile=logfile, do_build=do_build, testing=testing, modtool=self.modtool)
  File "/tmp/runner/3d5a10931cf2e751ef06d2399c598a7f9581f7da/lib/python3.8/site-packages/easybuild/main.py", line 456, in main
    new_pr_from_branch(options.new_pr_from_branch)
  File "/tmp/runner/3d5a10931cf2e751ef06d2399c598a7f9581f7da/lib/python3.8/site-packages/easybuild/tools/github.py", line 1612, in new_pr_from_branch
    print_msg('\n'.join(msg), log=_log)
TypeError: sequence item 4: expected str instance, list found

@boegel boegel added the bug fix label May 25, 2021
@boegel boegel added this to the 4.4.0 milestone May 25, 2021
@boegel boegel requested review from akesandgren and removed request for akesandgren May 25, 2021 20:53
migueldiascosta
migueldiascosta approved these changes May 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented May 26, 2021

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 097db73 into easybuilders:develop May 26, 2021
@boegel boegel deleted the fix_new_pr_from_branch branch May 26, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @migueldiascosta