correctly strip extension from filename in extract_cmd and back_up_file functions#3705
Merged
boegel merged 4 commits intoeasybuilders:developfrom May 27, 2021
Merged
correctly strip extension from filename in extract_cmd and back_up_file functions#3705boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
… error message for extension stripping in test for back_up_file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the original module file is named
2020a.luathen the backup generated will start with2020.bak_. This is becauserstrip('.lua')removes any of the characters.,l,u, orafound at the end of the string until it hits a character that is not one of those.I've searched the framework and these look to be the only problematic uses of
rstrip.