avoid overwritting pr_nr in post_pr_test_report for reports with --include-easyblocks-from-pr#3724
Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom Jun 5, 2021
Conversation
…clude-easyblocks-from-pr
Member
|
Going in, thanks @lexming! |
boegel
reviewed
Jun 5, 2021
| if build_option('include_easyblocks_from_pr'): | ||
| if repo_type == GITHUB_EASYCONFIGS_REPO: | ||
| easyblocks_pr_nrs = [int(pr_nr) for pr_nr in build_option('include_easyblocks_from_pr')] | ||
| easyblocks_pr_nrs = [int(eb_pr_nr) for eb_pr_nr in build_option('include_easyblocks_from_pr')] |
Member
There was a problem hiding this comment.
A safer fix would be using for x in , since we don't use single-letter variables outside of list comprehensions... :)
Member
There was a problem hiding this comment.
Also, can we come up with a way to make the tests trip over this?
|
flake8 should catch this (https://www.flake8rules.com/rules/F812.html) https://www.python.org/dev/peps/pep-3100/ perhaps flake8 is ignoring this test because it is not an issue, since flake8 is run in python3 in the tests, I think adding an extra flake8 that runs as python2 would catch these... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue discussed in easybuilders/easybuild-easyconfigs#9902 (comment)
The problem is that this
pr_nrvariable in the list comprehension is overwriting thepr_nrvariable in thepost_pr_test_reportscope.