Skip to content

Add option to ignore failing test step#3732

Merged
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:ignore_test_failure
Jul 1, 2021
Merged

Add option to ignore failing test step#3732
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:ignore_test_failure

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

Users can now use --ignore-test-failure instead of --skip-test-step which will run the tests but does not abort on error and just prints it instead.

Using both options doesn't make sense and is hence disallowed and a warning is show to make users move to ignoring failures instead of skipping the test completely.

Flamefire added 2 commits June 8, 2021 15:32
Users can now use --ignore-test-failure instead of --skip-test-step
which will run the tests but does not abort on error and just prints it instead.

Using both options doesn't make sense and is hence disallowed and a
warning is show to make users move to ignoring failures instead of
skipping the test completely.
@boegel boegel added this to the next release (4.4.1) milestone Jun 9, 2021
@easybuilders easybuilders deleted a comment from boegelbot Jun 9, 2021
Comment thread easybuild/framework/easyblock.py Outdated
Comment thread easybuild/framework/easyblock.py Outdated
Comment thread easybuild/framework/easyblock.py Outdated
Comment thread easybuild/framework/easyblock.py Outdated
Comment thread easybuild/main.py Outdated
Comment thread test/framework/options.py Outdated
Comment thread test/framework/options.py Outdated
Comment thread test/framework/options.py
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit c31e961 into easybuilders:develop Jul 1, 2021
@Flamefire Flamefire deleted the ignore_test_failure branch July 2, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants