Skip to content

add toolchain nvompic#3735

Merged
akesandgren merged 8 commits intoeasybuilders:developfrom
SebastianAchilles:nompi
Jun 28, 2021
Merged

add toolchain nvompic#3735
akesandgren merged 8 commits intoeasybuilders:developfrom
SebastianAchilles:nompi

Conversation

@SebastianAchilles
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles commented Jun 10, 2021 •
edited by akesandgren
Loading

This adds the nvompi toolchain: NVHPC + OpenMPI

akesandgren
akesandgren requested changes Jun 10, 2021
View reviewed changes
Comment thread easybuild/toolchains/nompi.py Outdated
@SebastianAchilles SebastianAchilles mentioned this pull request Jun 10, 2021
Closed
1 task
boegel
boegel previously requested changes Jun 11, 2021
View reviewed changes
Comment thread easybuild/toolchains/nompi.py Outdated
Comment thread easybuild/toolchains/nompi.py Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 11, 2021

@SebastianAchilles I'm not sure what's going on with the tests here...

@boegel boegel added this to the 4.x milestone Jun 11, 2021
@SebastianAchilles SebastianAchilles changed the title add toolchain nompi add toolchain nvompic Jun 11, 2021
@SebastianAchilles SebastianAchilles mentioned this pull request Jun 17, 2021
Closed
1 task
akesandgren
akesandgren requested changes Jun 28, 2021
View reviewed changes
Comment thread easybuild/toolchains/nvompic.py Outdated
Comment thread easybuild/toolchains/nvompic.py Outdated
@boegelbot
Copy link
Copy Markdown

boegelbot commented Jun 28, 2021

@SebastianAchilles: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-framework/actions/runs/978318613
Output from first failing test suite run:

FAIL: test_docstrings (test.framework.general.GeneralTest)
Make sure tags included in docstrings are correctly formatted.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/runner/1cbbcd4839df37c2ac90961b94f8b7b42f5039f5/lib/python2.7/site-packages/test/framework/general.py", line 124, in test_docstrings
    self.assertFalse(regex.search(txt), "No match for '%s' in %s" % (regex.pattern, path))
AssertionError: <_sre.SRE_Match object at 0x7f29c5f87d50> is not false : No match for '@author' in /tmp/runner/1cbbcd4839df37c2ac90961b94f8b7b42f5039f5/lib/python2.7/site-packages/easybuild/toolchains/nvompic.py

----------------------------------------------------------------------
Ran 782 tests in 979.604s

FAILED (failures=1)
ERROR: Not all tests were successful.

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@easybuilders easybuilders deleted a comment from boegelbot Jun 28, 2021
@easybuilders easybuilders deleted a comment from boegelbot Jun 28, 2021
@easybuilders easybuilders deleted a comment from boegelbot Jun 28, 2021
@akesandgren akesandgren dismissed boegel’s stale review June 28, 2021 10:59

Request for changes implemented

@easybuilders easybuilders deleted a comment from boegelbot Jun 28, 2021
@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Jun 28, 2021

Going in, thanks @SebastianAchilles!

@akesandgren akesandgren merged commit 76b6ab1 into easybuilders:develop Jun 28, 2021
@akesandgren akesandgren modified the milestones: 4.x, next release (4.4.1) Jun 28, 2021
@SebastianAchilles SebastianAchilles mentioned this pull request Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel left review comments

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@SebastianAchilles @boegel @boegelbot @akesandgren