add support for checksums specified in external checksums.json file#3749
add support for checksums specified in external checksums.json file#3749boegel merged 35 commits intoeasybuilders:developfrom
checksums.json file#3749Conversation
|
So far, I have assumed that one had either checksums in the EasyConfig file or a This is not really useful to reuse existing EasyConfigs with a bump I am rewriting the code such that both the checksums from the EasyConfig and the checksum from the Json file are loaded, and then providing a |
|
@boegel, do you think we need to address |
…s failing. removing it.
….json is picked up in test_checksum_step
….json, no need to hide it to make tests pass
|
@mboisson Some proposed cleanup for the test part of this in ComputeCanada#26 I intend to make a pass over the non-test part too to propose some minor improvements, but this looks really good overall, thanks for all the effort you've put into this already! 👍 |
generate test easyconfig without checksums to check whether checksums.json is picked up in test_checksum_step
tweaks + enhanced tests for checksums.json support
checksums.json file
… in checksums.json
tweak test_inject_checksums_to_json to avoid relying on order of keys in checksums.json
Renamed the branch since we switch from yaml to json.
This replaces #3748
to address
#3746
--inject-checksums(added--inject-checksums-to-json)I have tested this PR with
Python-3.8.2-GCCcore-9.3.0.ebby removing the checksums from the EasyConfig, and with--enforce-checksumsenabled.It allows to remove checksums both for the main file and for the exts_list.