Make logdir writable also when --stop/--fetch is used and --read-only-installdir is enabled#3771
Merged
akesandgren merged 5 commits intoeasybuilders:developfrom Aug 23, 2021
Merged
Conversation
03d9ab8 to
ff313ea
Compare
We often print an easyconfig which is currently shown as "<easybuild.framework.easyconfig.easyconfig.EasyConfig object at 0x7f431627df10>" This is not helpful at all. Instead show something like "GCC EasyConfig @ /tmp/GCC.eb"
Avoids failure with modules-env due to having no $MODULEPATH but an (otherwise inexistant) modules tool
ff313ea to
c866662
Compare
Contributor
|
Going in, thanks @Flamefire! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as for the usual installation:
--fetchor--stopalso write their logs into the installdir which fails when it is read-only.Turns out (in a test) we did then also make the whole installdir writable but not write-only again when the permissions-step is skipped (e.g. via --fetch). So undo our temporary writeable modification in that case.
Related to #3752
While debugging I included 2 minor changes:
<name> EasyConfig @ <path><unset>