include list of missing libraries in warning about missing FFTW libraries in imkl toolchain component#3776
Merged
ocaisa merged 3 commits intoeasybuilders:developfrom Jul 21, 2021
Merged
Conversation
ocaisa
approved these changes
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now also shows the missing libraries which helps when debugging such an error
Also some cleanup I've seen there and fixed the same issue in all files:
any([...])evaluates everything, allocates a list, then iterates over those to check for any false value, whileany(...)does only evaluate what is requires stopping early and doing no additional allocation --> Shorter and faster