Fix ignore_test_failure not set for Extension instances#3782
Merged
ocaisa merged 2 commits intoeasybuilders:developfrom Jul 21, 2021
Merged
Fix ignore_test_failure not set for Extension instances#3782ocaisa merged 2 commits intoeasybuilders:developfrom
ocaisa merged 2 commits intoeasybuilders:developfrom
Conversation
The ExtensionEasyBlock does not call __init__ from EasyBlock and hence that value is not set making uses of report_test_failure fail.
ocaisa
approved these changes
Jul 21, 2021
Member
|
I checked our shipped easyblocks and |
Contributor
Author
This was very recently introduced (shortly before last release) and as the extension EB shows might be unreliable. So should be fine |
Member
|
Thanks for the fix @Flamefire, going in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ExtensionEasyBlock does not call
__init__from EasyBlock and hence that value is not set making uses of report_test_failure fail.