Skip to content

ensure that path configuration options have absolute path values#3832

Merged
akesandgren merged 7 commits intoeasybuilders:developfrom
boegel:ensure_cfg_abs_paths
Sep 15, 2021
Merged

ensure that path configuration options have absolute path values#3832
akesandgren merged 7 commits intoeasybuilders:developfrom
boegel:ensure_cfg_abs_paths

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 13, 2021

This could be considered a bug fix or an enhancement, depending on your point of view...

fixes #3619, fixes #3830

@easybuilders easybuilders deleted a comment from boegelbot Sep 13, 2021
Comment thread easybuild/tools/options.py Outdated
Comment thread easybuild/tools/options.py
Comment thread easybuild/tools/options.py
Comment thread test/framework/options.py Outdated
… test_config_abs_path to also check on robot and robot-paths configuration options
Comment thread test/framework/options.py Outdated
Comment thread easybuild/tools/options.py Outdated
@easybuilders easybuilders deleted a comment from boegelbot Sep 14, 2021
…rately, due to special treatment needed for --robot argument
@easybuilders easybuilders deleted a comment from boegelbot Sep 14, 2021
akesandgren
akesandgren previously approved these changes Sep 14, 2021
Comment thread easybuild/tools/options.py Outdated
@akesandgren akesandgren dismissed their stale review September 14, 2021 11:16

Found one more thing that needs clarification

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 5bb9c54 into easybuilders:develop Sep 15, 2021
@boegel boegel deleted the ensure_cfg_abs_paths branch September 15, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trouble with DB-18.1.40 in foss-2020b --fetch fails for a git download when using a relative path for --sourcepath

2 participants