Skip to content

only print the hook messages if EasyBuild is running in debug mode#3843

Merged
ocaisa merged 2 commits intoeasybuilders:developfrom
Flamefire:silence_hooks
Oct 27, 2021
Merged

only print the hook messages if EasyBuild is running in debug mode#3843
ocaisa merged 2 commits intoeasybuilders:developfrom
Flamefire:silence_hooks

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

The output is VERY noisy, especially with parse_hook and module_write hook
The log already has this info and if you want it back you can use --debug

The output is VERY noisy, especially with parse_hook and module_write hook
The log already has this info and if you want it back you can use --debug
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree with this, will poll the other maintainers...

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me!

boegel
boegel previously requested changes Oct 27, 2021
Comment thread easybuild/tools/hooks.py
@boegel boegel added this to the 4.5.0 (next release) milestone Oct 27, 2021
@boegel boegel added the change label Oct 27, 2021
@ocaisa ocaisa dismissed boegel’s stale review October 27, 2021 08:35

Agreed to go with just --debug

@ocaisa ocaisa merged commit 0abef70 into easybuilders:develop Oct 27, 2021
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Oct 27, 2021

Gone in, thanks @Flamefire !

@Flamefire Flamefire deleted the silence_hooks branch October 27, 2021 09:29
@boegel boegel changed the title Print the hook messages only for debug-mode only print the hook messages if EasyBuild is running in debug mode Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants