remove '--depth 1' from git clone when 'commit' is specified in git_config#3871
Merged
ocaisa merged 2 commits intoeasybuilders:developfrom Oct 26, 2021
Merged
Conversation
Member
|
Rather than remove this optimisation, can't we just add an |
Member
Author
Yes, that makes sense. Though it has to be |
ocaisa
approved these changes
Oct 26, 2021
Member
|
LGTM, going in! Thanks @branfosj |
Member
|
@branfosj How difficult would it be to add a test that triggers the bug being fixed here? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)fixes #3870
The
--depth 1breaks any git download where we want to switch to a commit, as that commit will not be in the git history that we've downloaded.edit (by @boegel): for reference: this problem was introduced in commit 956fa9c which is a part of #3795 that was merged for EasyBuild v4.4.2